Change Room’s Access to/from Space members #5979

ganfra · 2026-01-08T13:36:38Z

Content

This PR allows to change the room access of a room/space to SpaceMembers, aka Restricted.
It also supports the knockRestricted feature.

Motivation and context

Closes #5650

Screenshots / GIFs

See recorded screenshots.

Tests

Create a room and add it to 2 spaces using EW
Makes sure you have space settings and ask to join enabled in dev settings
Open Securty&Privacy screen on EXA
Check you have all the room access options defined
Play with the options.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

# Conflicts: # features/roomdetails/impl/src/main/res/values/localazy.xml # features/securityandprivacy/impl/src/main/res/values/localazy.xml # libraries/ui-strings/src/main/res/values/localazy.xml

…paces

ElementBot · 2026-01-08T13:37:45Z

	Warnings
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L7 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L35 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L242 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L246 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L277 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L292 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L304 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L333 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-fr/translations.xml#L441 - For locale "fr" (French) the following quantity should also be defined: `many` (e.g. "1000000 de jours")
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L7 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L35 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L241 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L245 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L276 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L291 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L303 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L332 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-pt-rBR/translations.xml#L440 - For locale "pt" (Portuguese) the following quantity should also be defined: `many`
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L7 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L36 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L242 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L247 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L278 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L294 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L307 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L336 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L445 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 75c73be

github-actions · 2026-01-08T13:47:21Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bXNn4e

codecov · 2026-01-08T17:23:16Z

Codecov Report

❌ Patch coverage is 83.14286% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.41%. Comparing base (9878e8b) to head (9a30e4d).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ndprivacy/impl/root/SecurityAndPrivacyPresenter.kt	78.04%	8 Missing and 10 partials ⚠️
...nageauthorizedspaces/ManageAuthorizedSpacesView.kt	78.08%	9 Missing and 7 partials ⚠️
...d/libraries/matrix/impl/spaces/RustSpaceService.kt	0.00%	13 Missing ⚠️
...ityandprivacy/impl/root/SecurityAndPrivacyState.kt	78.43%	5 Missing and 6 partials ⚠️
...rityandprivacy/impl/root/SecurityAndPrivacyView.kt	96.77%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5979      +/-   ##
===========================================
+ Coverage    81.34%   81.41%   +0.06%     
===========================================
  Files         2545     2551       +6     
  Lines        67792    68119     +327     
  Branches      8683     8740      +57     
===========================================
+ Hits         55146    55458     +312     
+ Misses        9426     9417       -9     
- Partials      3220     3244      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Move authorized space selection state to a shared StateHolder scoped to RoomScope. This simplifies communication between SecurityAndPrivacy and ManageAuthorizedSpaces nodes by replacing the complex coroutine-based parent-child coordination with a reactive state flow pattern.

bmarty

Nice work, thanks!

Two remarks on the UI/UX:

When a room is in 2 spaces, the UI flow on its "Security & privacy" screen is a bit weird when the user clicks on "Space members" or "Ask to join":

The title of the screen displayed after the click is always the same and maybe wrong for the "Ask to join" case.

Secondly, maybe the item "Choose which spaces'..." could be moved below the selected option for clarity instead of being at the bottom of the "Access" option:

Sorry if this has been discussed with design and product before, I am just reporting feedback as if I was a regular user.

bmarty · 2026-01-09T15:06:14Z

...droid/features/securityandprivacy/impl/manageauthorizedspaces/ManageAuthorizedSpacesEvent.kt

@@ -0,0 +1,17 @@
+/*
+ * Copyright (c) 2025 Element Creations Ltd.
+ * Copyright 2025 New Vector Ltd.


New files should only have the 2025 (or 2026) Element Creations Ltd. line. Can you check all the new files in the PR please?

bmarty · 2026-01-09T15:16:11Z

...ndroid/features/securityandprivacy/impl/manageauthorizedspaces/ManageAuthorizedSpacesView.kt

+import io.element.android.libraries.ui.strings.CommonStrings
+
+@Composable
+fun ManageAuthorizedSpacesView(


Can you add a Figma link in comment for ref please?

bmarty · 2026-01-09T15:22:14Z

...rix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/spaces/RustSpaceService.kt

-                }
+            innerSpaceService
+                .topLevelJoinedSpaces()
+                .map(spaceRoomMapper::map)


sonarqubecloud · 2026-01-09T17:06:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ganfra added 16 commits December 23, 2025 15:22

feature(security&privacy): create ManageAuthorizedSpace classes

485585d

localazy : sync strings

7645588

# Conflicts: # features/roomdetails/impl/src/main/res/values/localazy.xml # features/securityandprivacy/impl/src/main/res/values/localazy.xml # libraries/ui-strings/src/main/res/values/localazy.xml

feature(security&privacy): start ManageAuthorizedSpacesView

161733b

localazy: sync strings

4a0e654

space service : expose methods from sdk

c398c62

feature(security&privacy): start branching logic of ManageAuthorizedS…

f64cb6e

…paces

quality: rename class

6a4ab9b

feature(security&privacy): make spaceSelection part of the state

cdc3cdc

feature(security&privacy): check SpaceSettings ff

887e59b

feature(security&privacy): iterate on SpaceMember option

4e9d5c5

feature(security&privacy): working SpaceMember selection

0d11c43

feature(security&privacy): support KnockRestricted join rule

8da3a3a

quality: add bunch of tests for Security&Privacy new features

b3463a5

Fix SecurityAndPrivacy preview state configuration

6eaf608

quality : format and clean

b3a934b

Merge branch 'develop' into feature/fga/space_members_access

0668135

ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Feature For a new feature labels Jan 8, 2026

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 8, 2026

ElementBot and others added 4 commits January 8, 2026 13:49

Update screenshots

bf7afd5

Add comprehensive presenter tests for SecurityAndPrivacy feature

c02a61e

Fix SecurityAndPrivacy "manage spaces" footer text

ea7e8e7

quality: move tests to matching package

184e0fb

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 8, 2026

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 8, 2026

ganfra marked this pull request as ready for review January 8, 2026 16:42

ganfra requested a review from a team as a code owner January 8, 2026 16:42

ganfra removed the request for review from a team January 8, 2026 16:42

ganfra requested a review from bmarty January 8, 2026 16:42

Update screenshots

29f50d0

ganfra removed the request for review from bmarty January 8, 2026 22:45

ganfra requested a review from bmarty January 9, 2026 11:01

bmarty approved these changes Jan 9, 2026

View reviewed changes

quality : fix PR remarks

75c73be

ganfra enabled auto-merge January 9, 2026 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change Room’s Access to/from Space members #5979

Change Room’s Access to/from Space members #5979

ganfra commented Jan 8, 2026

Uh oh!

ElementBot commented Jan 8, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

bmarty left a comment

Uh oh!

bmarty Jan 9, 2026

Uh oh!

bmarty Jan 9, 2026

Uh oh!

bmarty Jan 9, 2026

Uh oh!

sonarqubecloud bot commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Change Room’s Access to/from Space members #5979

Are you sure you want to change the base?

Change Room’s Access to/from Space members #5979

Conversation

ganfra commented Jan 8, 2026

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

ElementBot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

bmarty Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

bmarty Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 9, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ElementBot commented Jan 8, 2026 •

edited

Loading

github-actions bot commented Jan 8, 2026 •

edited

Loading

codecov bot commented Jan 8, 2026 •

edited

Loading